fix: propagate dependency generation failures#736
Draft
bdice wants to merge 1 commit into
Draft
Conversation
Collaborator
|
IIRC we don't return the error exit code because we don't want to fail when generating for additional file keys that some projects have and others don't. We do this in the DLFW builds when we pass |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rapids-build-utilsto26.8.8Context
In rapidsai/kvikio#996,
rapids-dependency-file-generatorwrote a partial requirements list before rejecting an invalid pip map. The devcontainers wrapper discarded stderr and collected successful process-substitution output, so the generator failure was hidden and the incomplete requirements file was installed. The later build then surfaced the unrelated-looking missing-Cython error.This change makes the wrapper fail at the dependency-generation boundary and keeps partial child output out of its stdout. The companion generator-side change is rapidsai/dependency-file-generator#188.
Testing
devcontainer features test --project-folder ./features --features rapids-build-utils --base-image ubuntu:22.04bash -non both modified dependency scripts and the feature testgit diff --check