Repository navigation
Add geomGetDominantSurroundingRectangle and rename SSR type - #308
Merged
Merged
Conversation
bhousel
added a commit
that referenced
this pull request
May 19, 2026
closes #267 closes #308 closes facebook/Rapid#1045
bhousel
changed the title
bhousel
added a commit
to bhousel/Rapid
that referenced
this pull request
May 19, 2026
(closes facebook#1045) see rapideditor/rapid-sdk#267 and rapideditor/rapid-sdk#308 This new approach can pick better surrounding rectangles in cases where the shape has zigzags or L-shape. The "smallest" rectangle would often appear at an angle. Instead, the computed "dominant" rectangle considers the weighted-edge angles as "votes" and builds a rectangle using more long edges.
bhousel
added a commit
that referenced
this pull request
May 21, 2026
Add centroid, longAxis, shortAxis fields to SurroundingRectangle. Remove redundant geomGetSurroundingRectangle; extract _normalizeAngle, _getRotatedExtent, and _buildSurroundingRectangle private helpers. geomGetDominantSurroundingRectangle no longer needs a convex hull. _getRotatedExtent delegates to geomRotate + Extent.extendSelf (no duplicate trig). Remove Edge type; vecProject now returns Closest (same shape: index/distance/point). Add extensive inline comments explaining the rotate-extent-rotate algorithm. Update CHANGELOG for pre.5. closes #308
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
geomGetLongestSurroundingRectanglegeomDominantSurroundingRectanglealongside the existinggeomGetSmallestSurroundingRectangle, and renames theSSRinterface toSurroundingRectangle.Changes
geomGetLongestSurroundingRectangle— returns the surrounding rectangle whose longest side is maximized. This may result in generating a more intuitive bounding box around features with a dominant axis (like buildings), and may be useful for placing labels and icons aligned to a building's dominant axis.SSR→SurroundingRectanglefor clarity.getSurroundingRectanglehelper, differing only in their scoring strategy.Setkeyed onMath.round(angle / ANGLE_EPSILON), avoiding testing of redundant rotations.reducewith afor...ofloop for extent accumulation; inlined rotation math to avoid allocating a temporary rotated-polygon array.offAxisLShapedBuildingPoints) and assertions verifying both functions choose the correct envelope orientation.👉 Update
After some testing I ended up using a different approach and making a new function
geomGetDominantSurroundingRectangle.The previous approach of selecting the "longest" edge would always pick a hypotenuse, generating diamond shapes around everything, which is not at all what we want.
Instead we'll compute an “edge-length-weighted dominant orientation” - use the outline segments as "votes" for an axis, fold perpendicular edges into the same bucket, then build the enclosing rectangle from there.
See 4f9d086
Closes #267
Closes facebook/Rapid#1045