Skip to content

Removed based view from thereadevents (#2192) #2202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
raydeal wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Removed based view from thereadevents (#2192) #2202

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 2 additions & 26 deletions misago/threadevents/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,37 +15,13 @@
from .hide import hide_thread_event, unhide_thread_event
from .models import ThreadEvent
from .threadeventtypes import (
BaseThreadEventType,
private_thread_event_type,
thread_event_type,
)
from .threadflag import sync_thread_has_events


class BaseEventView(BaseThreadView):
thread_event_type: BaseThreadEventType

def get_thread_event_queryset(
self,
request: HttpRequest,
thread: Thread,
) -> QuerySet:
return self.thread_event_type.get_thread_event_queryset(request, thread)

def get_thread_event(
self,
request: HttpRequest,
thread: Thread,
thread_event_id: int,
*,
select_related: bool | Iterable[str] = False,
) -> ThreadEvent:
return self.thread_event_type.get_thread_event(
request, thread, thread_event_id, select_related=select_related
)


class EventVisibilityView(BaseEventView):
class EventVisibilityView(BaseThreadView):
template_name: str = "misago/thread_events/event.html"
success_message: str

Expand Down Expand Up @@ -140,7 +116,7 @@ class PrivateThreadEventUnhideView(EventUnhideView):
thread_event_type = private_thread_event_type


class EventDeleteView(BaseEventView):
class EventDeleteView(BaseThreadView):
template_name: str = "misago/thread_events/delete.html"
confirm_template_name: str = "misago/thread_events/confirm_delete.html"
success_message = pgettext_lazy("thread event deleted", "Thread event deleted")
Expand Down
Loading