Repository navigation
Release/0.3.0 - #99
Merged
Merged
Conversation
1-Improve docs 2-Remove RadicalExecutionBackend from docs 3-Address Gemini comments
- Rename rose/al → rose/active_learning, rose/rl → rose/reinforcement_learning, rose/uq → rose/uncertainty_quantification so directory names match their content. No breaking changes: rose/__init__.py binds `from . import active_learning as al` and populates sys.modules with every rose.al.* short path, so all existing `from rose.al.active_learner import X` imports continue to work unchanged. - Add rose/cli.py and register the `rose` console script in pyproject.toml. `rose run workflow.yaml --local` runs any ROSE workflow locally using the rhapsody concurrent backend, eliminating the local.py boilerplate file. - Update rose/spec/builder.py deferred imports to the new package paths. - Update docs and README to use the short package-level aliases (from rose.al import X, from rose.rl import X, from rose.uq import X) instead of submodule paths.
Ports amsc/use-cases/service_utils.py's discover/launch/teardown flow into ROSE proper, updated for radical.orbit's current API (BridgeClient/ EndpointClient no longer exist — replaced by EndpointRuntime) and made spec-driven instead of interactive, matching --local's design. - rose/remote.py: new module — bootstrap a remote endpoint via IRI (OLCF), SFAPI (NERSC — IRI's /compute/* is broken server-side there), or PsiJ on an already-connected login node; wait for registration; run the workflow; tear down. - rose/spec/schema.py: RemoteConfig.target (TargetConfig) describes the bootstrap job (account/queue/walltime/tunnel/etc.). - rose/spec/__init__.py: fix stale bridge_url= kwarg passed to rhapsody's OrbitExecutionBackend (renamed to broker_url upstream) — was a silent TypeError waiting to happen. - rose/cli.py: --remote flag, mutually exclusive with --local. Also adds remote.embedded: hosts the ORBIT broker in-process (EmbeddedBroker, new upstream) instead of requiring an already-running one. Combined with target.kind: psij, drops target.edge_name entirely — PsiJ loads directly on the embedded broker, so `rose run --remote` on a login node needs no separate bootstrap endpoint at all. Tests: 30 new/extended unit tests (schema validation, mocked EndpointRuntime/EmbeddedBroker orchestration). Verified against real, unmocked radical.orbit (embedded broker + live PSIJClient resolution) in addition to the CLI entry point end-to-end with mocks. Docs: spec-api.md (remote.target, remote.embedded), rose-aas.md (bootstrap automation, no-broker-required callout).
- move rose/bootstrap.py + rose/remote.py into rose/remote/ (bootstrap.py, execute.py) with a public __init__.py re-export, matching the active_learning/reinforcement_learning/spec package convention - add TargetConfig.endpoint_timeout_min and `rose setup --wait-timeout` so the HPC endpoint-registration wait is configurable instead of a hardcoded 300s/30min, with a default-used warning when omitted - restyle mkdocs-material theme/CSS to match RHAPSODY's doc site conventions (flat header/tabs, pill buttons, forced heading color, pymdownx.highlight) while keeping ROSE's rose/pink palette - add a Command-Line Interface reference page documenting `rose run` and `rose setup`, cross-linked from spec-api.md and rose-aas.md
ROSE Spec for Service
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.