Skip to content

fix: simplify null and undefined checks in get function #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OgabekYuldoshev wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: simplify null and undefined checks in get function #426

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6761f26
fix: simplify null and undefined checks in get function
Aug 5, 2025
db38bc5
fix(get): treat null as undefined for default value
Aug 11, 2025
a0cec4b
Merge branch 'main' into fix-object-get
OgabekYuldoshev Aug 11, 2025
7198b56
Merge branch 'main' into fix-object-get
OgabekYuldoshev Sep 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions src/object/get.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,7 @@ export function get<TDefault = unknown>(
const segments = path.split(/[\.\[\]]/g)
let current: any = value
for (const key of segments) {
if (current === null) {
return defaultValue as TDefault
}
if (current === undefined) {
if (current === undefined || current === null) {
Comment thread
OgabekYuldoshev marked this conversation as resolved.
Outdated
return defaultValue as TDefault
}
const unquotedKey = key.replace(/['"]/g, '')
Expand All @@ -35,7 +32,7 @@ export function get<TDefault = unknown>(
}
current = current[unquotedKey]
}
if (current === undefined) {
if (current === undefined || current === null) {
return defaultValue as TDefault
}
return current
Expand Down
Loading