feat: add breakFunc argument to use break in the “map” function - #312
Open
moowoonsunghoon wants to merge 1 commit into
Open
feat: add breakFunc argument to use break in the “map” function#312moowoonsunghoon wants to merge 1 commit into
breakFunc argument to use break in the “map” function#312moowoonsunghoon wants to merge 1 commit into
Conversation
breakFunc argument to use break in the “map” function.
breakFunc argument to use break in the “map” function.breakFunc argument to use break in the “map” function
Member
|
Hey @moowoonsunghoon, thanks for the PR! I appreciate you taking the time to contribute. I think this could be a useful addition, but the use case may not be super common. That said, we can keep the PR open to gauge interest from the community. In the meantime, you can achieve a similar result using a const prices: number[] = []
for (const symbol of stockSymbols) {
const price = await calculateStockPrice(symbol)
prices.push(price)
if (sum(prices) > 100) {
break
}
}Personally, I find the Thanks again for the contribution. I look forward to seeing more from you in the future! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tip
The owner of this PR can publish a preview release by commenting
/publishin this PR. Afterwards, anyone can try it out by runningpnpm add radashi@pr<PR_NUMBER>.Summary
This PR adds the
breakFuncargument to usebreakin the “map” function.Related issue, if any:
For any code change,
Does this PR introduce a breaking change?
No
Bundle impact
src/async/map.tsFootnotes
Function size includes the
importdependencies of the function. ↩