fix: use consistent readable model labels - #166
Merged
sadsfae merged 2 commits intoSep 29, 2026
Merged
Conversation
Use a shared Python helper for onboarding, admin responses, and generated OpenCode, Pi, and OMP configuration names. Preserve raw API identifiers, token scopes, defaults, and explicit OMP operator names. Replace frontend normalization with server-provided labels, including saved offline selections. Cover approved profiles, fallback labels, private-model visibility, and identifier preservation with regressions. Refs: PERFSCALE-5951
Match the locked project version to 0.1.0-dev.2 so locked dependency installation succeeds. Dependency versions are unchanged.
ttlogan
reviewed
Sep 29, 2026
ttlogan
left a comment
ttlogan
left a comment
Contributor
There was a problem hiding this comment.
This reads clean. The display label now gets derived once, server-side, in model_display_name(), and every surface routes through it: onboarding model_names, the AdminNodeResponse model_display_name computed field, and all three harness/config generators. Raw IDs stay intact as the request identity, only the visible label changes, which is the right split. The GGUF/MTP suffix stripping keeps the edge cases (publisher/-GGUF, model-MTP) intact and the tests cover them. Also nice to have the duplicated JS displayName dropped in favor of the single server-supplied map.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PERFSCALE-5951
Use one Python helper for model display names across onboarding, admin responses, and generated OpenCode, Pi, and OMP configurations. Labels omit the publisher and GGUF packaging suffixes while preserving model variants, API identifiers, token scopes, and configured defaults. OMP downloads retain explicit operator-defined names.
Replace the frontend naming regex with server-supplied labels, including saved selections for offline models. Add regressions for the four approved profiles, raw-ID fallbacks, private-model visibility, operator-name precedence, and unchanged configuration identifiers.
Validation: 2,886 tests passed with 93.82% coverage, including real Chromium interaction checks. Ruff lint and formatting, strict mypy, ShellCheck, JavaScript syntax checks, and git diff --check passed. Validation used the separate one-line lockfile correction required by development’s release bump.