-
Notifications
You must be signed in to change notification settings - Fork 0
[FIX] endpoint, endpoint_json2: serialize response payloads with json_default #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
7edaf54
[FIX] endpoint_json2: serialize Domain field values to JSON
smorita7749 ef1d40e
[FIX] endpoint: serialize payload values with Odoo's json_default
yostashiro 139ec4c
[IMP] endpoint_json2: rely on json_default for response serialization
yostashiro 1d937d0
[IMP] endpoint, endpoint_json2: cover the response encoder hook
yostashiro a5193bf
[IMP] endpoint: state the encoder hook contract precisely
yostashiro File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When an endpoint's custom hook handles only an additional type—for example,
Decimal—and the same payload contains an Odoo-supported value such as a date orDomain,json.dumpsinvokes only the custom hook. If that hook follows the normal protocol and raisesTypeErrorfor values it does not handle, the request returns a serialization error instead of falling back to Odoo's encoder as promised. Selecting one callable withordoes not chain them; wrap the custom hook so unhandled values delegate tojson_default, or require the hook itself to delegate.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in a5193bf. The behaviour is intentional:
json.dumpstakes a singledefault=callable, and chaining would mean catchingTypeErroraround the hook, which would also swallow genuine errors raised inside it. The contract is that a custom hook replaces the default for the whole payload and delegates tojson_defaultfor the types it does not render itself — which is whatendpoint_json2._json2_json_defaultdoes. The comment (and the PR description) claimed automatic fallback and has been corrected.