fix(deps)!: attempt core, extension-link major upgrade — verification failed, needs review (Aikido) - #628
Draft
molon wants to merge 1 commit into
Draft
fix(deps)!: attempt core, extension-link major upgrade — verification failed, needs review (Aikido)#628molon wants to merge 1 commit into
molon wants to merge 1 commit into
Conversation
…link@3.29.2 (Aikido security advisories) Automated upgrade attempt that did not pass local verification. See the PR description for what fails and why. Not ready to merge as-is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrade dependencies with known vulnerabilities reported by Aikido Security:
@tiptap/core: 2.27.2 → 3.29.2@tiptap/extension-link: 2.27.2 → 3.29.2Aikido findings resolved
ui/vuetifyx/vuetifyxjs/pnpm-lock.yamlui/vuetifyx/vuetifyxjs/pnpm-lock.yamlCovers 2 Aikido sub-issues across 2 finding groups. Some sub-issues are detections inside built container images; they clear once the image is rebuilt from this change.
What fails
Resolved versions were checked against the lockfile / module graph — not just the manifest edit, because a bumped manifest can still resolve to the old version when another constraint pins it:
@tiptap/extension-link→3.29.2(wanted3.29.2, via lockfile (ui/vuetifyx/vuetifyxjs))@tiptap/core→2.27.2(wanted3.29.2, via lockfile (ui/vuetifyx/vuetifyxjs))Build does not pass after the upgrade:
pnpm buildinui/vuetifyx/vuetifyxjs(same command passes on the base commit, so this is caused by the upgrade)What a reviewer needs to decide: whether this upgrade is worth doing now (and who adapts the breaking changes), or whether it should wait. The alternative is to keep the current vulnerable version.
Build passes:
pnpm installinui/vuetifyx/vuetifyxjsAlready failing on the base commit (verified by re-running the same command on
64587dfd4), unrelated to this change:pnpm test:unitinui/vuetifyx/vuetifyxjsNotes
release-*branch.