Skip to content

S3 - GetURL returns path if Endpoint set #15

Description

This seems like unexpected behavior but I wanted to make sure.

It appears as though if the Endpoint is set or the ACL is set to a BucketCannedACLPrivate or s3.BucketCannedACLAuthenticatedRead the interface will return the path that was passed in.

Storage.GetURL(obj.Src) // returns obj.Src

Expected behavior:

If Endpoint is set it would return {Endpoint}{path} or if there is no endpoint and public ACL it would return the standard URL for the S3 bucket Region.

I'd be happy to make a pull request for this functionality, but I would like to make sure this is the expected behavior.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions