Skip to content

additional emulator fixes - #1499

Merged
lballerio merged 19 commits into
mainfrom
after_unitaryhack
Jul 9, 2026
Merged

additional emulator fixes#1499
lballerio merged 19 commits into
mainfrom
after_unitaryhack

Conversation

@lballerio

@lballerio lballerio commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@lballerio
lballerio marked this pull request as ready for review June 18, 2026 10:11
@lballerio
lballerio requested review from a team June 18, 2026 10:11
@lballerio lballerio changed the title After unitaryhack After unitaryhack bugs Jun 18, 2026
@lballerio lballerio changed the title After unitaryhack bugs My own bugs Jun 18, 2026
@codecov

codecov Bot commented Jun 18, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 67.96875% with 41 lines in your changes missing coverage. Please review.
✅ Project coverage is 39.04%. Comparing base (0064190) to head (3aa05be).

Files with missing lines Patch % Lines
...qibolab/_core/instruments/emulator/engine/qutip.py 43.90% 23 Missing ⚠️
src/qibolab/_core/instruments/emulator/emulator.py 60.46% 17 Missing ⚠️
...olab/_core/instruments/emulator/engine/dynamiqs.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1499      +/-   ##
==========================================
- Coverage   39.50%   39.04%   -0.47%     
==========================================
  Files         119      120       +1     
  Lines        6219     6203      -16     
==========================================
- Hits         2457     2422      -35     
- Misses       3762     3781      +19     
Flag Coverage Δ
unittests 39.04% <67.96%> (-0.47%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lballerio lballerio changed the title My own bugs additional emulator fixes Jun 18, 2026
@lballerio
lballerio force-pushed the after_unitaryhack branch from 0d4e080 to f87155d Compare June 18, 2026 11:04
@RoyStegeman

Copy link
Copy Markdown
Member

Can this be closed now #1497 has been merged?

@alecandido
alecandido marked this pull request as draft June 18, 2026 12:19
@lballerio
lballerio force-pushed the after_unitaryhack branch 2 times, most recently from 50809d0 to 766f256 Compare June 22, 2026 05:59
@lballerio
lballerio marked this pull request as ready for review June 22, 2026 11:41
Comment thread src/qibolab/_core/instruments/emulator/engine/abstract.py Outdated
Comment thread src/qibolab/_core/instruments/emulator/engine/dynamiqs.py
Comment thread src/qibolab/_core/instruments/emulator/engine/qutip.py
Comment thread src/qibolab/_core/instruments/emulator/engine/qutip.py Outdated
Comment thread src/qibolab/_core/instruments/emulator/engine/qutip.py Outdated
Comment thread src/qibolab/_core/instruments/emulator/engine/qutip.py Outdated
Comment thread src/qibolab/_core/instruments/emulator/engine/qutip.py Outdated
Comment thread src/qibolab/_core/instruments/emulator/emulator.py Outdated
Comment thread src/qibolab/_core/instruments/emulator/engine/qutip.py
@lballerio

Copy link
Copy Markdown
Contributor Author

also rebased on actual main after #1505 was merged into main.

@lballerio
lballerio force-pushed the after_unitaryhack branch from 202e1a7 to eb487e6 Compare July 3, 2026 11:56

@alecandido alecandido left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last few comments, but they are very minor. It seems ready

Comment thread tests/instruments/emulator/test_dynamiqs.py Outdated
Comment thread src/qibolab/_core/instruments/emulator/engine/qutip.py Outdated
Comment thread src/qibolab/_core/instruments/emulator/emulator.py
Comment thread src/qibolab/_core/instruments/emulator/emulator.py Outdated
@lballerio
lballerio requested a review from alecandido July 8, 2026 14:32
@alecandido
alecandido force-pushed the after_unitaryhack branch from 8690668 to 3aa05be Compare July 8, 2026 16:19
@lballerio
lballerio added this pull request to the merge queue Jul 9, 2026
Merged via the queue into main with commit 3bb101b Jul 9, 2026
39 checks passed
@lballerio
lballerio deleted the after_unitaryhack branch July 9, 2026 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants