Keysight batching support - #1460
Draft
sorewachigauyo wants to merge 1 commit into
Draft
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1460 +/- ##
==========================================
- Coverage 37.45% 37.33% -0.13%
==========================================
Files 114 114
Lines 5900 5919 +19
==========================================
Hits 2210 2210
- Misses 3690 3709 +19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently in the keysight driver, there is no preprocessing for the batching, which means the entire list of
PulseSequences is passed to the driver for compilation.Since the 2Q RB has switched to batching, our execution now fails because the compiler cannot resolve such a large sequence.
This PR aims to fix this by introducing a preprocessing step for the batching to cut down the number of sequences per execution.
As a test case, we cut down the time for a 7 pair 2Q RB from 270-280s (no batching/single circuit execution) to 200-210s for the same workload. Though, the time saving is actually larger (actual execution time is about 170s) because the time for the RB sequence generation has increased due to the implementation in qiboteam/qibocal#1490 compared to the circuit reuse in qiboteam/qibocal#1416.
rb-2q-fast.tar.gz
TODO: