Cr sequences by jevillegasdatTII · Pull Request #994 · qiboteam/qibocal

jevillegasdatTII · 2024-10-02T09:33:55Z

Checklist:

Reviewers confirm new code works as expected.
Tests are passing.
Coverage does not decrease.
Documentation is updated.
Compatibility with Qibo modules (Please edit this section if the current pull request is not compatible with the following branches).
- Qibo: master
- Qibolab: 0.1
- Qibolab_platforms_qrc: main

Closed previous pull request #987 and make this one with a change in the sequenced routine.

codecov · 2024-10-02T09:40:24Z

Codecov Report

Attention: Patch coverage is 72.85714% with 114 lines in your changes missing coverage. Please review.

Project coverage is 96.39%. Comparing base (0a8b3a4) to head (a1d134b).
Report is 5 commits behind head on cross_resonance.

Files with missing lines	Patch %	Lines
...t_interaction/cross_resonance/chevron_frequency.py	49.45%	46 Missing ⚠️
...ction/cross_resonance/cross_resonance_sequences.py	38.57%	43 Missing ⚠️
...ols/two_qubit_interaction/cross_resonance/utils.py	0.00%	25 Missing ⚠️

Additional details and impacted files

@@                 Coverage Diff                 @@
##           cross_resonance     #994      +/-   ##
===================================================
- Coverage            97.53%   96.39%   -1.15%     
===================================================
  Files                  123      129       +6     
  Lines                 9703    10072     +369     
===================================================
+ Hits                  9464     9709     +245     
- Misses                 239      363     +124

Flag	Coverage Δ
unittests	`96.39% <72.85%> (-1.15%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
src/qibocal/protocols/__init__.py	`100.00% <100.00%> (ø)`
src/qibocal/protocols/ramsey/ramsey.py	`99.00% <100.00%> (-0.09%)`	⬇️
src/qibocal/protocols/ramsey/ramsey_signal.py	`97.54% <100.00%> (-0.10%)`	⬇️
src/qibocal/protocols/ramsey/utils.py	`100.00% <100.00%> (ø)`
src/qibocal/protocols/state_tomography.py	`98.65% <100.00%> (+0.10%)`	⬆️
...ibocal/protocols/two_qubit_interaction/__init__.py	`100.00% <100.00%> (ø)`
...protocols/two_qubit_interaction/chevron/chevron.py	`97.05% <ø> (-2.21%)`	⬇️
.../two_qubit_interaction/cross_resonance/__init__.py	`100.00% <100.00%> (ø)`
...s/two_qubit_interaction/cross_resonance/chevron.py	`100.00% <100.00%> (ø)`
...bit_interaction/cross_resonance/cross_resonance.py	`100.00% <100.00%> (ø)`
... and 4 more

... and 3 files with indirect coverage changes

jevillegasdatTII · 2024-10-02T10:35:37Z

Results in #987 (comment)

Edoardo-Pedicillo

Thanks @jevillegasdatTII. Before merging to main, could you update the protocol section of the Qibocal documentation (https://qibo.science/qibocal/stable/protocols/index.html) with a description of these routines, following the same style? You can check here https://github.com/qiboteam/qibocal/tree/main/doc/source/protocols for some examples.

Edoardo-Pedicillo · 2024-10-03T14:15:54Z

 @dataclass
 class CrossResonanceChevronParameters(Parameters):
-    """ResonatorSpectroscopy runcard inputs."""
+    """cross resonance chevron runcard inputs."""


Start the docstrings with the capital letter

Edoardo-Pedicillo · 2024-10-03T14:42:45Z

+    0(I):
+        Q_C: Pulse(omega_T, t)  - MZ
+        Q_T: wait               - MZ
+    1(X):
+        Q_C: RX   - Pulse(omega_T, t)  - MZ
+        Q_T:      - wait               - MZ


I suggest explaining the pulse sequence in a sentence, because it could create possible rendering issues and some symbols are not defined.

Edoardo-Pedicillo · 2024-10-03T14:42:55Z

+@dataclass
+class CrossResonanceSeqData(Data):
+    """Data structure for Cross Resonance Gate Calibration using Sequences.
+    targets: [target, control]


Suggested change

targets: [target, control]

Edoardo-Pedicillo · 2024-10-03T14:43:27Z

+    from qibolab.pulses import Pulse, Rectangular, PulseType, Gaussian
+    from qibolab.native import NativePulse


Move these lines on top

Edoardo-Pedicillo · 2024-10-03T14:50:41Z

+                        phi = results[qubit].phase
+                        data.register_qubit(
+                            CrossResonanceType,
+                            (qubit, target, control, tgt_setup, ctr_setup),


Why do you need to store qubit?

Edoardo-Pedicillo · 2024-10-03T14:56:33Z

+from qibolab.platform import Platform
+from qibolab.qubits import QubitId, QubitPairId
+
+def cr_pulse_sequence(platform: Platform, pair: QubitPairId, setup: tuple, duration:int=0, amplitude:int = None):


This function is not used, but (I didn't check carefully) it could be used in cross_resonance and the signal one to avoid code duplication.

for more information, see https://pre-commit.ci

Merge branch 'pi_half' of github.com:qiboteam/qibocal into pi_half

We changed the default runcard option to False (by default will calibrate pi pulse)

Merge branch 'pi_half' of github.com:qiboteam/qibocal into pi_half

…ored data

Bumps [jinja2](https://github.com/pallets/jinja) from 3.1.4 to 3.1.5. - [Release notes](https://github.com/pallets/jinja/releases) - [Changelog](https://github.com/pallets/jinja/blob/main/CHANGES.rst) - [Commits](pallets/jinja@3.1.4...3.1.5) --- updated-dependencies: - dependency-name: jinja2 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>

chore(deps): bump jinja2 from 3.1.4 to 3.1.5

Propagate #1077 to 0.2

Update to qibolab 0.2

This reverts commit b5d0417, reversing changes made to 2343e0a.

…to cr_sequences

…ccept to select in which bases to measure and the setup of the target qubit.

…ude)

…e routine.

andrea-pasquale · 2025-08-27T06:28:41Z

@jevillegasdatTII is this PR still necessary? Seems to be quite outdated with respect to main. Also keep in mind that for CR there are already several protocols tested by @Luca-Ben-Herrmann in #860. I suggest to close it and keep the branch in case we want something compatible with 0.1 just for debugging.

jevillegasdatTII requested a review from andrea-pasquale October 2, 2024 09:33

Edoardo-Pedicillo self-requested a review October 2, 2024 12:33

Edoardo-Pedicillo reviewed Oct 3, 2024

View reviewed changes

Edoardo-Pedicillo requested a review from hay-k October 3, 2024 15:02

Edoardo-Pedicillo added this to the Qibocal 0.1.1 milestone Oct 3, 2024

Edoardo-Pedicillo and others added 23 commits November 20, 2024 10:31

fix: change n_targets

1c8d9e0

refactor: readout mitigation matrix acquisition and post-processing

87b4ebd

fix: propagate changes in the other routines and fix tests

6cd7e29

fix: remove pickle

f35f166

modified classes and methods for running rabi for RX90

9f63c69

added option to save duration of RX90 pulse

33db217

started modifying rabi ef for using RX90

32cceda

modified pihalf_pulse to rx90 in parameters

7661361

Update rabi.rst

d03f383

[pre-commit.ci] auto fixes from pre-commit.com hooks

d0c1228

for more information, see https://pre-commit.ci

set pi calibration as default and change rx90 dtype

e6a2395

Saving modified documentation

144f468

Merge branch 'pi_half' of github.com:qiboteam/qibocal into pi_half

fix ordering error

c112748

moved all pihalf_pulses in Rabi-Data class

f083434

fix: circuit execution issue

b7a9249

moved all pihalf_pulses in Rabi-Data class

f52765f

fixed errors

efcb55a

Update rabi.rst

66f0b71

We changed the default runcard option to False (by default will calibrate pi pulse)

fix: use 2q circuits

a5f5dd0

fixed amplitude_sequence and length_sequence inputs

1f16f50

Sync remote and local branches

f8e9021

Merge branch 'pi_half' of github.com:qiboteam/qibocal into pi_half

fix: add check before dumping the mitigation matrix

4c0013a

fixed acquisition error

a08cf3c

jevillegasd and others added 27 commits February 15, 2025 09:52

Change in load serialize to allow tuples as keys when loading from st…

b4009dc

…ored data

Update pyproject.toml

db86dd8

Merge branch 'main' into cr_sequences

2343e0a

Merge pull request #1087 from qiboteam/dependabot/pip/jinja2-3.1.5

7a25e48

chore(deps): bump jinja2 from 3.1.4 to 3.1.5

Merge branch 'main' into 0.2

6d7f8a6

refactor: Adopt recent compiler changes to 0.2

6870e02

test: Add test for natives

826aed9

refactor: Alessandro suggestions

8328a81

Merge pull request #1090 from qiboteam/fix_natives_0.2

acffe0f

Propagate #1077 to 0.2

Merge pull request #990 from qiboteam/0.2

cc2da88

Update to qibolab 0.2

Merge branch 'main' into cr_sequences

b5d0417

update of plotting function for cnot calibration

6ef9a39

Revert "Merge branch 'main' into cr_sequences"

6509fe7

This reverts commit b5d0417, reversing changes made to 2343e0a.

Merge branch 'cr_sequences' of https://github.com/qiboteam/qibocal in…

896289e

…to cr_sequences

Homogenous plotting function, and length and amplitude routines now a…

fc02680

…ccept to select in which bases to measure and the setup of the target qubit.

Fitting for length routine.

e6468ac

Fitting for the Jeff (effective coupling foir a given CR pulse amplit…

9beb9b3

…ude)

cnot calibration in amplitude

bef6fb3

update cnot_amplitude

c26470c

update cr_cnot

d1a9448

fix for uploading in dalma

0518ec4

Merge branch '0.1' into cr_sequences

ed1b7c7

Eletrical delay on dispersie shift and sweeper for resonator amplitud…

a25f1a3

…e routine.

update on phase unwrap

b49f168

Update in phase delay correction for punchout (axis of unwrap was worng)

04929b4

reshape data and saved the strctured one to the acquisition results.

defc952

modified: src/qibocal/protocols/resonator_spectroscopy.py

f36fc6e

jevillegasd closed this Feb 4, 2026

Navigation Menu

Uh oh!

Cr sequences - #994

Cr sequences#994
jevillegasdatTII wants to merge 568 commits into
cross_resonancefrom
cr_sequences

jevillegasdatTII commented Oct 2, 2024 •

edited by Edoardo-Pedicillo

Loading

Uh oh!

codecov Bot commented Oct 2, 2024 •

edited

Loading

Uh oh!

jevillegasdatTII commented Oct 2, 2024

Uh oh!

Edoardo-Pedicillo left a comment •

edited

Loading

Uh oh!

Edoardo-Pedicillo Oct 3, 2024

Uh oh!

Edoardo-Pedicillo Oct 3, 2024

Uh oh!

Edoardo-Pedicillo Oct 3, 2024

Uh oh!

Edoardo-Pedicillo Oct 3, 2024

Uh oh!

Edoardo-Pedicillo Oct 3, 2024

Uh oh!

Edoardo-Pedicillo Oct 3, 2024

Uh oh!

andrea-pasquale commented Aug 27, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

		from qibolab.pulses import Pulse, Rectangular, PulseType, Gaussian
		from qibolab.native import NativePulse

Uh oh!

Conversation

jevillegasdatTII commented Oct 2, 2024 • edited by Edoardo-Pedicillo Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Oct 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

jevillegasdatTII commented Oct 2, 2024

Uh oh!

Edoardo-Pedicillo left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Edoardo-Pedicillo Oct 3, 2024

Choose a reason for hiding this comment

Uh oh!

Edoardo-Pedicillo Oct 3, 2024

Choose a reason for hiding this comment

Uh oh!

Edoardo-Pedicillo Oct 3, 2024

Choose a reason for hiding this comment

Uh oh!

Edoardo-Pedicillo Oct 3, 2024

Choose a reason for hiding this comment

Uh oh!

Edoardo-Pedicillo Oct 3, 2024

Choose a reason for hiding this comment

Uh oh!

Edoardo-Pedicillo Oct 3, 2024

Choose a reason for hiding this comment

Uh oh!

andrea-pasquale commented Aug 27, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

jevillegasdatTII commented Oct 2, 2024 •

edited by Edoardo-Pedicillo

Loading

codecov Bot commented Oct 2, 2024 •

edited

Loading

Edoardo-Pedicillo left a comment •

edited

Loading