Skip to content

Refactor CelebA target_type validation with verify_str_arg #9544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mhafizazh wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −3
Open

Refactor CelebA target_type validation with verify_str_arg #9544

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions torchvision/datasets/celeba.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,7 @@ def __getitem__(self, index: int) -> tuple[Any, Any]:

target: Any = []
for t in self.target_type:
t = verify_str_arg(t, arg="target_type", valid_values=["attr", "identity", "bbox", "landmarks"])
if t == "attr":
target.append(self.attr[index, :])
elif t == "identity":
Expand All @@ -185,9 +186,6 @@ def __getitem__(self, index: int) -> tuple[Any, Any]:
target.append(self.bbox[index, :])
elif t == "landmarks":
target.append(self.landmarks_align[index, :])
else:
# TODO: refactor with utils.verify_str_arg
raise ValueError(f'Target type "{t}" is not recognized.')

if self.transform is not None:
X = self.transform(X)
Expand Down