Fix tkinter.OptionMenu callback type - #16113
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
srittau
requested changes
Jul 31, 2026
srittau
left a comment
srittau
left a comment
Collaborator
There was a problem hiding this comment.
Thanks, just a note about tests.
| root.after(1000, foo, 10, "lol") | ||
| root.after(1000, foo, 10, 10) # type: ignore | ||
|
|
||
| tkinter.OptionMenu(root, tkinter.StringVar(), "option", command=lambda value: assert_type(value, str)) |
Collaborator
There was a problem hiding this comment.
Since our tests are never run, they are only checked against type checkers, this test doesn't do much. We try to keep our tests minimal, so this isn't needed.
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
srittau
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OptionMenupasses the selected menu value to_setit, which invokes the callback with that value rather than theStringVar. Update both version-specific signatures to type the callback argumentas
str, and add a regression test for callback inference.CPython implementation: https://github.com/python/cpython/blob/main/Lib/tkinter/__init__.py#L4573-L4615
Fixes #16111