Improve mapping type completeness - #573
Closed
heejaechang wants to merge 2 commits into
Closed
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Author
|
Closing after policy cleanup: the branch now matches master exactly, and no independently valuable checker-clean residual change remains. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closed after policy review. The proposed completeness gains depended on reparameterizing declarations that already carried explicit
# type: ignore[type-arg]ownership boundaries, adding checker-specific suppressions, and adding inference-only annotations whose primary value was the VerifyTypes score.Commit
116f4c9restorestomlkit/container.pyandtomlkit/items.pyexactly to currentmaster, removing every suppression and annotation introduced by this PR. No independently valuable, checker-clean residual change remained, so the PR no longer has a meaningful diff.Cleanup validation:
poetry run pre-commit run --all-files(pass)poetry run pytest -q tests(1,051 passed)poetry run mypy(same 29 pre-existing clean-master errors)poetry run pyright --verifytypes tomlkit --ignoreexternal(restored master baseline: 382 known / 47 ambiguous / 44 unknown across 473 exports; 80.7611%)Agent Drafting Metadata