Repository navigation
Conversation
Subtests measured time with time.time()/time.perf_counter() looked up on the time module, so a test mocking them (freezegun, time-machine, monkeypatch) produced negative durations and 0.0 stop timestamps in reports. Switch _SubTestContextManager to _pytest.timing.Instant()/elapsed(), the same helpers regular tests use via runner.py, which bind the real time functions at import and are immune to such mocking. Fixes pytest-dev#15201.
pyba-chronographer
Bot
added
the
bot:chronographer:provided
Member
|
ai misconduct |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subtests measured their duration with
time.time()/time.perf_counter()looked up on the
timemodule, so a test mocking them (for example withfreezegun,time-machine, ormonkeypatch) produced negative durationsand
0.0stop timestamps in reports._SubTestContextManagernow uses_pytest.timing.Instant()/.elapsed(),the same helpers regular tests use via
runner.py. They bind the real timefunctions at import time and are therefore immune to such mocking, which is
exactly what
_pytest.timingexists for (see its docstring, issue #185).Fixes #15201.