Feature/manually mark faces - #1678
Open
HerbertHorst wants to merge 5 commits into
Open
Conversation
added 5 commits
June 2, 2026 21:51
Add a modal to manually mark a face region in a photo and assign it to a person (existing or new), with an option to use the marked face for clustering. Also supports reassigning an existing face to another person. - New FaceManualAddModal.vue: photo picker + drag-to-mark UI - New DAV helpers in services/dav/face.ts (getFacesForFile, addManualFace, reassignFace) + IFaceRectForFile type - Wire up entry points in Metadata.vue and FaceTopMatter.vue Pairs with the facerecognition backend endpoints for manual faces.
faceRecognitionAddManualFace() return type now includes clusteringQueued. After saving a manual face with 'use for clustering' checked, show an info toast if the backend signals that no descriptor is available yet so the user understands the limitation without silent failure.
The info message now appears only when the face was actually queued (clusteringQueued=true) and explains that the next background scan will look for a face in the marked area and use it for automatic recognition only if one is found.
Add datalist-based autocompletion of already-known person names to both name fields in FaceManualAddModal (new manual face and reassignment), sourced from the facerecognition face list. Mirrors the suggestions shown when naming an unknown cluster; silently shows no suggestions if the list cannot be loaded.
The standard "Rename person" dialog now offers the same name autocompletion as the manual-face modal. On open it loads existing person names from the active backend (recognize or facerecognition, chosen via routeIsRecognize) and exposes them through a native datalist on the name field. Numeric cluster ids are filtered out, names are deduped and sorted, and any load failure is non-fatal (no suggestions shown).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the option to tag a face manual using face recognition.
New "Add face manually" modal:
Name autocomplete also added to the standard Rename person dialog.
This is the frontend half of the feature. It relies on matching backend API routes added in matiasdelellis/facerecognition#841
Showcase of the outlines when opening a picture:
and when you click on a face you can reasign who this is
