Proposal: Allow Selection in Viewer - #1584
Open
jacksbox wants to merge 2 commits into
Open
Conversation
Signed-off-by: Mario Jäckle <github@jacksbox.de>
Signed-off-by: Mario Jäckle <github@jacksbox.de>
Author
|
@pulsejet Could you give me some feedback if this is a desired feature / general feedback to this PR? I would love to continue working on this, and/or on other memories features. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I create a proposal how selecting in the full screen viewer window could achieved (see my issue #1581). It retains the selection when switching between viewer and timeline view.
The PR would still need some smoothing down, there are to lint erros and there are two issues I still need to solve:
selectionManagerthe image seems to be there. But when leaving the viewer, the image is not selected anymore. This does not happen if there is a image selected before going in the viewer mode.I have not much experience developing in vue, so I'm really happy about early feedback.