Skip to content

refactor(accounts): AccountFollowモデルでフォロー解除する - #1841

Merged
MikuroXina merged 1 commit into
mainfrom
refactor/1838-account-follow-delete
Sep 14, 2026
Merged

MikuroXina merged 1 commit into
mainfrom
refactor/1838-account-follow-delete

Conversation

@laminne

@laminne laminne commented Sep 11, 2026

Copy link
Copy Markdown
Member

close #1838

What does this PR do?

Additional information

@laminne
laminne added this pull request to stack #1843 September 11, 2026 15:33
Comment thread pkg/accounts/service/unfollow.ts Outdated
@laminne
laminne marked this pull request as ready for review September 11, 2026 15:38
@laminne
laminne requested a review from MikuroXina September 11, 2026 15:41
Comment thread pkg/accounts/service/unfollow.ts Outdated
Base automatically changed from chore/1836-delete-domain-events to main September 12, 2026 11:09
@MikuroXina
MikuroXina force-pushed the refactor/1838-account-follow-delete branch from bd0184d to 3e494c8 Compare September 12, 2026 11:09
@codecov

codecov Bot commented Sep 12, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 70.58824% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.69%. Comparing base (9fce9e3) to head (0d175d4).

Files with missing lines Patch % Lines
pkg/accounts/adaptor/repository/prisma/prisma.ts 0.00% 3 Missing ⚠️
pkg/accounts/service/unfollow.ts 84.61% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1841      +/-   ##
==========================================
+ Coverage   47.65%   47.69%   +0.04%     
==========================================
  Files         171      171              
  Lines        5901     5910       +9     
  Branches      891      893       +2     
==========================================
+ Hits         2812     2819       +7     
- Misses       3089     3091       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@laminne
laminne force-pushed the refactor/1838-account-follow-delete branch from 3e494c8 to 2d2994f Compare September 13, 2026 04:55
Co-authored-by: Mikuroさいな <10331164+MikuroXina@users.noreply.github.com>
@laminne
laminne force-pushed the refactor/1838-account-follow-delete branch from 2d2994f to 0d175d4 Compare September 13, 2026 05:00
@laminne
laminne requested a review from MikuroXina September 13, 2026 05:02
@MikuroXina
MikuroXina added this pull request to the merge queue Sep 14, 2026
Merged via the queue into main with commit 90949c9 Sep 14, 2026
6 checks passed
@MikuroXina
MikuroXina deleted the refactor/1838-account-follow-delete branch September 14, 2026 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor: AccountFollowRepository.unfollowでフォロー解除しているのをやめる

2 participants