Repository navigation
Test Improvements - #32
Merged
Merged
Conversation
midnightveil
commented
Jun 16, 2026
phsauter
requested changes
Jun 16, 2026
phsauter
left a comment
phsauter
left a comment
Collaborator
There was a problem hiding this comment.
Some things that might be worth reviewing but we could merge as-is.
midnightveil
force-pushed
the
upstreamable-tests
branch
3 times, most recently
from
June 25, 2026 05:56
d9e1d48 to
0a34d80
Compare
phsauter
previously approved these changes
Jun 26, 2026
phsauter
left a comment
phsauter
left a comment
Collaborator
There was a problem hiding this comment.
A minor request but otherwise its ready to be merged.
Collaborator
|
Can you please rebase on the current master, we had some CI problems and I would like to see everything pass here before merging. |
1 similar comment
Collaborator
|
Can you please rebase on the current master, we had some CI problems and I would like to see everything pass here before merging. |
The current version of AXI was released in late-2025, but it has incompatibilities that prevent it from being run in simulation under VCS, so update it and the other dependencies to newer versions. Also adds temporary files generated by VCS to .gitignore.
This allows you to see how each different kind of test affects the varying event counters exposed. Useful for future commits modifying the tests to test functionality using the event counters.
They all sort of blur together with the perf counter printing.
This is easier to read and @phsauter also prefers it.
This adds a test for the issue fixed by PR 22, where this resulted in the cache getting stuck in bypass mode. Note that this test is unable to identify the issue in PR 22
We can utilise the event counters to make the tests able to check behaviour of the cache; that is, whether events are causes misses/hits in the LLC ways and thus test configuration of SPM vs LLC has been set correctly.
midnightveil
force-pushed
the
upstreamable-tests
branch
from
June 30, 2026 02:11
0a34d80 to
f9b738f
Compare
Contributor
Author
|
OK, rebased now. |
thommythomaso
approved these changes
Jul 2, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
flushedhandling, fix hang on flush #30 and config: Support coalesced explicit and SPM flushes #22