Skip to content

Fix crash when editing profile for non-existent user #11875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mowems wants to merge 3 commits into
base: main
Choose a base branch
from
+23 −10
Open

Fix crash when editing profile for non-existent user #11875

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e65642b
Fix crash when editing profile for non-existent user
mowems Apr 27, 2026
a64762e
Handle numeric IDs and prevent crash when editing non-existent user
mowems Apr 27, 2026
6ef460f
Use route helpers for profile edit redirects
mowems Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 23 additions & 10 deletions app/controllers/users_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,15 +81,25 @@ def update
def edit
@action = "update" # sets the form url
@user = if params[:id] # admin only
User.find_by(username: params[:id])
else
current_user
end
if params[:id].to_s =~ /\A\d+\z/
User.find_by(id: params[:id])
else
User.find_by(username: params[:id])
end
else
current_user
end
unless @user
flash[:error] = I18n.t('users_controller.no_user_found_name', username: params[:id])
redirect_to root_path
return
end

if current_user && current_user.uid == @user.uid || logged_in_as(['admin'])
render template: "users/edit"
else
flash[:error] = I18n.t('users_controller.only_user_edit_profile', user: @user.name).html_safe
redirect_to "/profile/" + @user.name
redirect_to user_path(@user.username)
end
end

Expand Down Expand Up @@ -147,14 +157,17 @@ def list

def profile
if current_user && params[:id].nil?
redirect_to "/profile/#{current_user.username}"
redirect_to user_path(current_user.username)
elsif !current_user && params[:id].nil?
redirect_to "/"
redirect_to root_path
else
@profile_user = User.find_by(username: params[:id])
if !@profile_user
flash[:error] = I18n.t('users_controller.no_user_found_name', username: params[:id])
redirect_to "/"
flash[:error] = I18n.t(
'users_controller.no_user_found_name',
username: params[:id]
)
redirect_to root_path
else
@title = @profile_user.name
wikis = Revision.order("nid DESC")
Expand Down Expand Up @@ -186,7 +199,7 @@ def profile
flash.now[:error] = I18n.t('users_controller.user_has_been_banned')
else
flash[:error] = I18n.t('users_controller.user_has_been_banned')
redirect_to "/"
redirect_to root_path
end
elsif @profile_user.status == 5
flash.now[:warning] = I18n.t('users_controller.user_has_been_moderated')
Expand Down
Loading