Skip to content

chore: add trailing newlines to 7 files for POSIX compliance#11765

Open
janderik wants to merge 1 commit into
prowler-cloud:masterfrom
janderik:fix/trailing-newlines
Open

chore: add trailing newlines to 7 files for POSIX compliance#11765
janderik wants to merge 1 commit into
prowler-cloud:masterfrom
janderik:fix/trailing-newlines

Conversation

@janderik

@janderik janderik commented Jul 1, 2026

Copy link
Copy Markdown

Description

This PR adds missing trailing newlines to 7 files to ensure POSIX compliance. A file not ending with a newline is considered a broken or corrupted file by POSIX standards, and many tools (diff, cat, sed, awk, etc.) behave unexpectedly on such files.

This change is purely cosmetic and has no functional impact.

Files changed

  • contrib/k8s/helm/prowler-app/templates/api/configmap.yaml
  • contrib/k8s/helm/prowler-app/templates/api/role.yaml
  • prowler/compliance/aws/cis_7.0_aws.json
  • prowler/compliance/m365/cis_7.0_m365.json
  • prowler/providers/aws/aws_regions_by_service.json
  • ests/providers/aws/aws_regions_by_service.json
  • ests/providers/nhn/lib/mutelist/fixtures/nhn_mutelist.yaml"

Summary by CodeRabbit

  • Bug Fixes

    • Updated Kubernetes app permissions so service accounts are bound in the correct release namespace.
    • Fixed end-of-file formatting in region mapping data to ensure it is parsed cleanly.
  • Tests

    • Kept test fixtures in sync with the updated region and mutelist data.

Files affected:
- contrib/k8s/helm/prowler-app/templates/api/configmap.yaml
- contrib/k8s/helm/prowler-app/templates/api/role.yaml
- prowler/compliance/aws/cis_7.0_aws.json
- prowler/compliance/m365/cis_7.0_m365.json
- prowler/providers/aws/aws_regions_by_service.json
- tests/providers/aws/aws_regions_by_service.json
- tests/providers/nhn/lib/mutelist/fixtures/nhn_mutelist.yaml
@janderik janderik requested a review from a team as a code owner July 1, 2026 15:48
@github-actions github-actions Bot added provider/aws Issues/PRs related with the AWS provider compliance Issues/PRs related with the Compliance Frameworks community Opened by the Community labels Jul 1, 2026
@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Conflict Markers Resolved

All conflict markers have been successfully resolved in this pull request.

@coderabbitai

coderabbitai Bot commented Jul 1, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: dbcc2b63-42fd-40ab-96cb-3568da45c3c1

📥 Commits

Reviewing files that changed from the base of the PR and between d4e4d12 and da796f8.

⛔ Files ignored due to path filters (2)
  • prowler/compliance/aws/cis_7.0_aws.json is excluded by !prowler/compliance/**/*.json
  • prowler/compliance/m365/cis_7.0_m365.json is excluded by !prowler/compliance/**/*.json
📒 Files selected for processing (5)
  • contrib/k8s/helm/prowler-app/templates/api/configmap.yaml
  • contrib/k8s/helm/prowler-app/templates/api/role.yaml
  • prowler/providers/aws/aws_regions_by_service.json
  • tests/providers/aws/aws_regions_by_service.json
  • tests/providers/nhn/lib/mutelist/fixtures/nhn_mutelist.yaml

📝 Walkthrough

Walkthrough

This PR contains small, unrelated edits: a whitespace trim adjustment in a Helm ConfigMap template, addition of a namespace field to a ClusterRoleBinding subject, end-of-file formatting fixes in two AWS regions JSON files, and an added resource entry in an NHN mutelist test fixture.

Changes

Helm Template Updates

Layer / File(s) Summary
Helm template adjustments
contrib/k8s/helm/prowler-app/templates/api/configmap.yaml, contrib/k8s/helm/prowler-app/templates/api/role.yaml
Adjusts whitespace trim marker on the range loop's {{- end }} in the ConfigMap template, and adds namespace: {{ .Release.Namespace }} to the ClusterRoleBinding's ServiceAccount subject.

Data File Updates

Layer / File(s) Summary
AWS regions JSON EOF fixes
prowler/providers/aws/aws_regions_by_service.json, tests/providers/aws/aws_regions_by_service.json
Fixes end-of-file closing brace formatting in both JSON files with no content changes.
Mutelist fixture resource update
tests/providers/nhn/lib/mutelist/fixtures/nhn_mutelist.yaml
Adds "resource_2" to the Resources list for the compute_instance_public_ip check under subscription_1.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: jfagoagas

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description only includes a short summary and file list; it omits the required Context, Steps to review, and Checklist sections. Add the missing template sections with motivation/context, review steps, and checklist items, plus any issue links if applicable.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: adding trailing newlines for POSIX compliance.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Warning

⚠️ This pull request shows signs of AI-generated slop (description_diff_mismatch). It has been flagged by CodeRabbit slop detection and should be reviewed carefully.

@coderabbitai coderabbitai Bot added the slop label Jul 1, 2026
@jfagoagas jfagoagas removed the slop label Jul 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community Opened by the Community compliance Issues/PRs related with the Compliance Frameworks provider/aws Issues/PRs related with the AWS provider

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants