Repository navigation
Restructure Tests - #151
Merged
Merged
Conversation
kostis
approved these changes
Nov 3, 2026
kostis
left a comment
Member
There was a problem hiding this comment.
I am not very familiar with Java testing frameworks to know why Assertions is preferable than Assert, or why Jupiter is the way forward, but I like that repetitive code is gone from the test suite and this restructuring has a leaner look and feel. (And yes, it's good that we get rid of the output dir...)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR restructures the test suite making it easier to extend and prepares it for some upcoming test-related PRs.
Notable Changes
Moved tests to the packages of the classes they test.
Migrated to JUnit 6 (Jupiter) through the
junit-bom, and pinnedmaven-surefire-plugin.@TempDir, parameterized tests and better assertionsAdded shared test helpers to avoid repetitive code:
ConfigBuilders: provides config builder factoriesFixedAlphabetBuilder: an in-memory alphabet builderCliTestSupport: builds parsers and parses/asserts command-line argsAll test output now goes to
@TempDir../outputrun artifacts of some RA tests.Removed the unused
src/test/resources/default_alphabet.xml.The (98) tests have been maintained as previously.