Skip to content

Restructure Tests - #151

Merged
actyp merged 5 commits into
mainfrom
restructure-tests
Nov 3, 2026
Merged

actyp merged 5 commits into
mainfrom
restructure-tests

Conversation

@actyp

@actyp actyp commented Nov 3, 2026

Copy link
Copy Markdown
Member

This PR restructures the test suite making it easier to extend and prepares it for some upcoming test-related PRs.

Notable Changes

  • Moved tests to the packages of the classes they test.

  • Migrated to JUnit 6 (Jupiter) through the junit-bom, and pinned maven-surefire-plugin.

    • JUnit 6 provides @TempDir, parameterized tests and better assertions
  • Added shared test helpers to avoid repetitive code:

    • ConfigBuilders: provides config builder factories
    • FixedAlphabetBuilder: an in-memory alphabet builder
    • CliTestSupport: builds parsers and parses/asserts command-line args
  • All test output now goes to @TempDir.

    • This also removed the ./output run artifacts of some RA tests.
  • Removed the unused src/test/resources/default_alphabet.xml.

  • The (98) tests have been maintained as previously.

@actyp
actyp requested a review from kostis November 3, 2026 05:43

@kostis kostis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not very familiar with Java testing frameworks to know why Assertions is preferable than Assert, or why Jupiter is the way forward, but I like that repetitive code is gone from the test suite and this restructuring has a leaner look and feel. (And yes, it's good that we get rid of the output dir...)

@actyp
actyp merged commit 7e5b3c2 into main Nov 3, 2026
6 checks passed
@actyp
actyp deleted the restructure-tests branch November 3, 2026 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants