refactor(selinux): replace deprecated fact vars#845
Merged
SuperQ merged 1 commit intoJul 8, 2026
Merged
Conversation
github-actions
Bot
added
trivial
roles/_common
roles/alertmanager
roles/apache_exporter
roles/bind_exporter
roles/blackbox_exporter
roles/cadvisor
roles/chrony_exporter
roles/consul_exporter
roles/dns_exporter
roles/elasticsearch_exporter
roles/fail2ban_exporter
roles/gitlab_ci_pipelines_exporter
roles/influxdb_exporter
roles/ipmi_exporter
roles/memcached_exporter
roles/mongodb_exporter
roles/mysqld_exporter
roles/nginx_exporter
roles/node_exporter
roles/nvidia_gpu_exporter
roles/nvme_exporter
roles/pgbackrest_exporter
roles/postgres_exporter
roles/process_exporter
roles/prometheus
roles/pushgateway
roles/pve_exporter
roles/redis_exporter
roles/smartctl_exporter
labels
Signed-off-by: PendaGTP <38917281+PendaGTP@users.noreply.github.com>
PendaGTP
force-pushed
the
refactor/use-ansible_facts-in-selinux-tasks
branch
from
63b2c16 to
5aa9854
Compare
Contributor
Author
|
FYI CI failures are not related to this change but errors comes from rate limiting and timeouts. |
Contributor
|
Yes, tests that touch all roles tend to randomly fail due to the load. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently,
selinuxtasks use some ansible facts without usingansible_facts, this cause issue when usinginject_facts_as_vars = False, since these variables will not be defined.This PR address this issue.