Skip to content

[19635] fix: Add scope="col" to th elements for td-has-header a11y compliance #19636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fkwq34 wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[19635] fix: Add scope="col" to th elements for td-has-header a11y compliance #19636

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1ba7178
19635 fix: add scopes to table and tree table
Jun 23, 2026
7a47fed
19637 add role to steppers children
Jun 23, 2026
5788a59
Add mutation observer; Change th selector
Jun 24, 2026
35ad53b
Revert
Jun 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions packages/primeng/src/table/table.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1176,6 +1176,8 @@ export class Table<RowData = any> extends BaseComponent<TablePassThrough> implem

id: string = UniqueComponentId();

private thScopeObserver: MutationObserver | null = null;

styleElement: any;

responsiveStyleElement: any;
Expand Down Expand Up @@ -1353,6 +1355,7 @@ export class Table<RowData = any> extends BaseComponent<TablePassThrough> implem
if (this.isStateful() && this.resizableColumns) {
this.restoreColumnWidths();
}
this.initThScopeObserver();
}
}

Expand Down Expand Up @@ -3198,6 +3201,36 @@ export class Table<RowData = any> extends BaseComponent<TablePassThrough> implem

this.destroyStyleElement();
this.destroyResponsiveStyle();

if (this.thScopeObserver) {
this.thScopeObserver.disconnect();
this.thScopeObserver = null;
}
}

private initThScopeObserver() {
const thead = this.tableHeaderViewChild?.nativeElement;
if (!thead) {
return;
}

thead.querySelectorAll(':scope > tr > th:not([scope])').forEach((th: HTMLElement) => th.setAttribute('scope', 'col'));

this.thScopeObserver = new MutationObserver((mutations) => {
mutations.forEach((mutation) => {
mutation.addedNodes.forEach((node) => {
if (node.nodeType === Node.ELEMENT_NODE) {
const element = node as HTMLElement;
if (element.tagName === 'TH' && !element.hasAttribute('scope')) {
element.setAttribute('scope', 'col');
}
element.querySelectorAll?.('th:not([scope])').forEach((th: HTMLElement) => th.setAttribute('scope', 'col'));
}
});
});
});

this.thScopeObserver.observe(thead, { childList: true, subtree: true });
}

get dataP() {
Expand Down
42 changes: 42 additions & 0 deletions packages/primeng/src/treetable/treetable.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -914,6 +914,8 @@ export class TreeTable extends BaseComponent<TreeTablePassThrough> implements Bl

toggleRowIndex: Nullable<number>;

private thScopeObserver: MutationObserver | null = null;

onInit() {
if (this.lazy && this.lazyLoadOnInit && !this.virtualScroll) {
this.onLazyLoad.emit(this.createLazyLoadMetadata());
Expand Down Expand Up @@ -1033,6 +1035,12 @@ export class TreeTable extends BaseComponent<TreeTablePassThrough> implements Bl
});
}

onAfterViewInit() {
if (isPlatformBrowser(this.platformId)) {
this.initThScopeObserver();
}
}

filterService = inject(FilterService);

tableService = inject(TreeTableService);
Expand Down Expand Up @@ -2346,6 +2354,40 @@ export class TreeTable extends BaseComponent<TreeTablePassThrough> implements Bl
this.editingCellField = null;
this.editingCellData = null;
this.initialized = null;

if (this.thScopeObserver) {
this.thScopeObserver.disconnect();
this.thScopeObserver = null;
}
}

private initThScopeObserver() {
const theads = this.el.nativeElement.querySelectorAll(':scope thead');
if (!theads.length) {
return;
}

theads.forEach((thead: HTMLElement) => {
thead.querySelectorAll(':scope > tr > th:not([scope])').forEach((th: HTMLElement) => th.setAttribute('scope', 'col'));
});

this.thScopeObserver = new MutationObserver((mutations) => {
mutations.forEach((mutation) => {
mutation.addedNodes.forEach((node) => {
if (node.nodeType === Node.ELEMENT_NODE) {
const element = node as HTMLElement;
if (element.tagName === 'TH' && !element.hasAttribute('scope')) {
element.setAttribute('scope', 'col');
}
element.querySelectorAll?.('th:not([scope])').forEach((th: HTMLElement) => th.setAttribute('scope', 'col'));
}
});
});
});

theads.forEach((thead: HTMLElement) => {
this.thScopeObserver!.observe(thead, { childList: true, subtree: true });
});
}

get dataP() {
Expand Down