Repository navigation
Upgrade platform-go to v11.2.0 - #4
Merged
Merged
Conversation
The v10 -> v11 major bump changes the module path, so every import moves
from platform-go/v10 to platform-go/v11.
Nothing else had to move with it. Diffing the packages this template
actually consumes -- config, observability, observability/logging{,/config},
and the metrics/profiling/tracing noop providers -- against v10 with the
path rewrite normalized away shows no API changes at all; v11's additions
to config (render.go, envvars/) are purely additive. So this is the import
rewrite, the go.mod/go.sum bump, and the one CLAUDE.md line that spelled
the version out.
make configs re-renders config/localdev.json and config/production.json
byte-for-byte identically, so the checked-in projections are unchanged.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
verygoodsoftwarenotvirus
left a comment
verygoodsoftwarenotvirus
left a comment
Contributor
Author
There was a problem hiding this comment.
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the template from
platform-go/v10 v10.0.0toplatform-go/v11 v11.2.0.What's in here
A major version bump changes the module path, so the bulk of this is mechanical: every
github.com/primandproper/platform-go/v10/...import becomes.../v11/...acrossinternal/cli,internal/config, andcmd/tools/codegen/configs, plus the one line inCLAUDE.mdthat spelled the version out.Nothing else had to move with it. Diffing the packages this template actually consumes —
config,observability,observability/loggingand itsconfigsubpackage, and themetrics/profiling/tracingnoop providers — against v10 with the internal path rewritenormalized away turns up no API changes. v11's additions to
config(render.go,envvars/)are purely additive, so nothing here had to adapt to them.
Transitively:
fxamacker/cbor/v2v2.9.0 → v2.9.2, andswaggest/jsonschema-go+swaggest/reflarrive as new indirect deps (pulled in by v11's config additions).Verification
go build ./...andgo vet ./...cleanmake testpasses (race, shuffle, failfast)make lint— golangci-lint reports 0 issues, shellcheck passesmake configsre-rendersconfig/localdev.jsonandconfig/production.jsonbyte-for-byte identically, so the checked-in projections are unchanged
make build+./artifacts/template-go versionandversion --config config/localdev.jsonboth work, confirming the
LoadFromFilepath still round-tripsFollow-up, deliberately not in this PR
v11 adds
config.RenderJSONFiles(and TOML/YAML counterparts) upstream, which covers the sameground as this template's own
internal/config.Render. Swapping to it is a refactor rather thana version bump, so I left it alone — worth a separate PR if you want the template to lean on the
upstream renderer.
🤖 Generated with Claude Code