Implicit waitmovement 0 - #2322
Open
mrgriffin wants to merge 4 commits into
Open
Conversation
Collaborator
Author
|
Applied review suggestions: no more |
GriffinRichards
approved these changes
Jun 18, 2026
Applied to moverotatingtileobjects and turnrotatingtileobjects.
mrgriffin
force-pushed
the
pret-applywaitmovement
branch
from
June 18, 2026 14:22
88a48ab to
654b7fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convenience macros for eliminating some explicit
waitmovement 0s:applywaitmovement: Fusedapplymovementandwaitmovement 0.waitmovement 0formoverotatingtileobjectsandturnrotatingtileobjects.It is possible to create a variadic
applywaitmovementsmacro, but I didn't think it would be practical because the lines would become very long. The remainingwaitmovements are now mostly:special PlayerFaceTrainerAfterBattle(could not add an implicitwaitmovementhere because not all calls to that special immediatelywaitmovement).applymovements.Migration script for
applywaitmovement: migrate_applywaitmovement.py.WARNING: if there's complex control flow the linear "is it appropriate to fuse the
waitmovementwith the previousapplymovement" might fuse when there's technically two or moreapplymovements and an explicitwaitmovement 0would be more idiomatic. It should not produce an incorrect result, but as always try comparing thesha1sumof your ROM before/after migration.