fix: resolve rich platforms in workspace export conda-explicit-spec#6551
Open
MridulS wants to merge 2 commits into
Open
fix: resolve rich platforms in workspace export conda-explicit-spec#6551MridulS wants to merge 2 commits into
workspace export conda-explicit-spec#6551MridulS wants to merge 2 commits into
Conversation
lucascolley
reviewed
Jul 15, 2026
Comment on lines
+111
to
+118
| // Resolve the conda subdir to the environment's platform entry. Rich | ||
| // platforms (platforms carrying system-requirements) are stored in the lock | ||
| // file under generated aliases (e.g. `p1`, `p2`) rather than their subdir | ||
| // name, so we cannot look them up by `platform.to_string()`. Instead, match | ||
| // on the subdir of each platform the environment actually provides. | ||
| let lock_platform = | ||
| env.platforms() | ||
| .find(|p| p.subdir() == *platform) |
Collaborator
There was a problem hiding this comment.
Does this just match any rich platform of the same subdir? What if there are multiple?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
pixi workspace export conda-explicit-specresolved each environment's platform in the lock file by subdir name viaLockFile::platform(&platform.to_string()). Rich platforms (platforms carrying system-requirements) are keyed in the lock under generated aliases (p1,p2, ...) instead of their subdir, so the lookup returnedNoneand the command failed with something like:How Has This Been Tested?
I tested this out with this minimal example:
With the latest pixi release:
With this PR it works as expected.
AI Disclosure
Tools: Claude
Checklist:
schema/model.py.