Repository navigation
feat: refactor Individual metrics into ClassificationMetrics struct - #58
Merged
Merged
Conversation
… test errors remaining
Move classification-specific fields (auc, threshold, threshold_ci, sensitivity, specificity, accuracy, additional metrics) from flat Individual fields into a nested ClassificationMetrics struct. Individual.cls.auc replaces Individual.auc, etc. This separation enables future TaskMetrics enum for regression support (spearman, r_squared, mse, mae) without modifying classification code. All 749 lib tests pass. Serialization format updated (cls is a nested object, not flattened). Refs #45
… serde, hash, clone, evaluate)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cls: ClassificationMetricsstructIndividual.auc→Individual.cls.auc, etc.Individual.metrics(AdditionalMetrics) →Individual.cls.additionalfitstays on Individual as the universal penalized objectiveWhy
Enables future
TaskMetricsenum for regression support (#15) without modifying any classification code. Separates concerns: classification metrics are grouped together, ready for a siblingRegressionMetricsstruct.Test plan
Refs #45