Skip to content

Allow to hide rank display during gameplay - #38235

Open
MingxuanGame wants to merge 2 commits into
ppy:masterfrom
MingxuanGame:feat/hide-rank-during-gameplay
Open

Allow to hide rank display during gameplay#38235
MingxuanGame wants to merge 2 commits into
ppy:masterfrom
MingxuanGame:feat/hide-rank-during-gameplay

Conversation

@MingxuanGame

Copy link
Copy Markdown
2026-07-07.20-30-34_clip.mp4

@bdach bdach added the subjective PRs with subjective changes which have not been discussed prior. Need team consensus to proceed. label Jul 8, 2026
@peppy
peppy self-requested a review July 9, 2026 11:47
@peppy

peppy commented Jul 9, 2026

Copy link
Copy Markdown
Member

I was going to start going through this, but I'm again not sure about adding this per skin component like it is. It feels like people are going to start requesting this for other elements, which brings up the classic question:

  • Should there be a "during gameplay" layer where you can add any components you want?
  • Should there be a base class for skin components which handle settings like this which we want on all skin components?

@bdach interested in your thoughts on what direction to take here.

@bdach

bdach commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

If going by user wants then this is likely going to need to work an per-element toggle basis.

I don't think layers help here because layers as we currently have them will introduce implicit Z-ordering constraints (is the "during gameplay layer" above or below the "not during gameplay layer"?). Users also frequently have trouble understanding layers and that some components are only on some layers, though that is mostly an orthogonal concern which can probably be addressed via UX fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M subjective PRs with subjective changes which have not been discussed prior. Need team consensus to proceed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants