Repository navigation
add build script for tiktoken 0.13.0 - #8332
Merged
Merged
Conversation
Signed-off-by: Varsha Kumar <varsha.kumar@ibm.com>
cdeepali
approved these changes
Jun 30, 2026
Signed-off-by: Varsha Kumar <varsha.kumar@ibm.com>
Contributor
|
@cdeepali how do we get the checks to run the 0.13.0.sh file |
cdeepali
reviewed
Jun 30, 2026
| "docker_build": false, | ||
| "validate_build_script": true, | ||
| "use_non_root_user": false, | ||
| "v0.13.0":{ |
Contributor
There was a problem hiding this comment.
Suggested change
| "v0.13.0":{ | |
| "0.13.0":{ |
Contributor
|
@jcho02 pls remove v prefix from the version string in build-info.json eg - https://github.com/ppc64le/build-scripts/pull/8332/changes#r3499630849. |
Signed-off-by: Varsha Kumar <varsha.kumar@ibm.com>
Contributor
Done, can we re-do the checks? |
Contributor
|
I have restarted the checks. |
Contributor
|
Recording test results: |
shivansh-ibm
pushed a commit
to shivansh-ibm/build-scripts
that referenced
this pull request
Jul 14, 2026
* add build script for tiktoken 0.13.0 Signed-off-by: Varsha Kumar <varsha.kumar@ibm.com> * Changed line 20 to tiktoken_ubi_9.3.sh Signed-off-by: Varsha Kumar <varsha.kumar@ibm.com> * Added suggestion in line 13 Signed-off-by: Varsha Kumar <varsha.kumar@ibm.com> --------- Signed-off-by: Varsha Kumar <varsha.kumar@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
set -eoption enabled and observe success ?