Hide the wireless networks list when Wi-Fi is off - #1478
Open
LeandroPG19 wants to merge 1 commit into
Open
Conversation
The early return that skips the wireless section also required a known VPN to be present, so with Wi-Fi turned off and no VPN configured the list of visible wireless networks was still built and shown. Return whenever Wi-Fi is off, and push the VPN section only when there is one, which is what the airplane mode branch above already does. The VPN section that follows the wireless networks is now only reachable with Wi-Fi on, so its `wifi_enabled` check is dropped. Fixes pop-os#1470 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Leandro Pérez G. <leandropatodo@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The early return that skips the wireless section required a known VPN to be
present as well, so with Wi-Fi turned off and no VPN configured the list of
visible wireless networks was still built and shown. That is why the issue is
not reproducible on systems that have a VPN.
view_windownow returns whenever Wi-Fi is off, and pushes the VPN section onlywhen there is one, which is what the airplane mode branch just above it already
does.
The VPN section that follows the wireless networks is only reachable with Wi-Fi
on now, so its
wifi_enabledcheck is dropped.Fixes #1470