Skip to content

Change "input source text" applet to fixed width - #1458

Open
krakotay wants to merge 3 commits into
pop-os:masterfrom
krakotay:patch-1
Open

Change "input source text" applet to fixed width#1458
krakotay wants to merge 3 commits into
pop-os:masterfrom
krakotay:patch-1

Conversation

@krakotay

@krakotay krakotay commented Jul 2, 2026

Copy link
Copy Markdown

Just two lines, but important for multilingual UI/UX

  • I have disclosed use of any AI generated code in my commit messages.
    • If you are using an LLM, and do not fully understand the changes it is making to the code base, do not create a PR.
    • In our experience, AI generated code often results in overly complex code that lacks enough context for a proper fix or feature inclusion. This results in considerably longer code reviews. Due to this, AI authored or partially authored PRs may be closed without comment.
  • I understand these changes in full and will be able to respond to review comments.
  • My change is accurately described in the commit message.
  • My contribution is tested and working as described.
  • I have read the Developer Certificate of Origin and certify my contribution under its conditions.

Use a monospaced font for the layout indicator to prevent nearby tray items from shifting when the input source changes. This currently only affects two-letter indicators (e.g. us, fr, cn, ru).

@mmstick
mmstick requested review from a team July 2, 2026 16:04
mmstick
mmstick previously approved these changes Jul 2, 2026

@jacobgkau jacobgkau left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is an example of the problem this solves:

2026-07-02.14-28-08-cropped.mp4

Here it is on this branch:

2026-07-02.14-28-35-cropped.mp4

I want to mention, using a monospace font is not the only way to solve this. We could just ensure the applet has a fixed width (based on the number of characters, if necessary). We had someone propose using a monospace font for the clock for similar reasons earlier on (particularly for when seconds were enabled), but we were able to fix the shifting without using a monospace font: #635

It's up to UX if the switch to a monospace font is wanted or not. This is ready for QA approval once UX signs off.

@krakotay

krakotay commented Jul 3, 2026

Copy link
Copy Markdown
Author

In #635, I saw the comment from this May saying that the fixed-width applet feature still doesn't working on their system, but I havent check it myself.

Also, some input source labels can be longer than two letters. I don't think a fixed-width applet should either truncate a 10-letter input source label or leave empty space for a 2-letter one.

@jacobgkau

Copy link
Copy Markdown
Member

I don't think a fixed-width applet should either truncate a 10-letter input source label or leave empty space for a 2-letter one.

It wouldn't need to. You can just reserve X amount of space per character, can't you? This would only be a problem if a certain font was extremely wide, but the difference usually amounts to pixels.

@krakotay

krakotay commented Jul 9, 2026

Copy link
Copy Markdown
Author

Done, it should works.

2026-07-09.09-35-07.mp4

@krakotay krakotay changed the title Change input source text font to monospace Change "input source text" applet to fixed width Jul 9, 2026
@git-f0x

git-f0x commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

but we were able to fix the shifting without using a monospace font

Afaik the issue is still there, but the default Open Sans font has monospace numbers, so it's not noticeable with it.

@krakotay

Copy link
Copy Markdown
Author

@jacobgkau what do you think about?

@maria-komarova maria-komarova left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using fixed width as @jacobgkau suggested sounds good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants