Skip to content

feat: show week numbers - #1429

Open
NicolaiSoeborg wants to merge 4 commits into
pop-os:masterfrom
NicolaiSoeborg:master
Open

feat: show week numbers#1429
NicolaiSoeborg wants to merge 4 commits into
pop-os:masterfrom
NicolaiSoeborg:master

Conversation

@NicolaiSoeborg

Copy link
Copy Markdown

Controllable by cosmic-settings with this commit:
NicolaiSoeborg/cosmic-settings@de3be06 / pop-os/cosmic-settings#2028

Screenshots (dark / light theme):

WeekNumbers-DarkMode WeekNumbers-LightMode
  • I have disclosed use of any AI generated code in my commit messages.
    • If you are using an LLM, and do not fully understand the changes it is making to the code base, do not create a PR.
    • In our experience, AI generated code often results in overly complex code that lacks enough context for a proper fix or feature inclusion. This results in considerably longer code reviews. Due to this, AI authored or partially authored PRs may be closed without comment.
  • I understand these changes in full and will be able to respond to review comments.
  • My change is accurately described in the commit message.
  • My contribution is tested and working as described.
  • I have read the Developer Certificate of Origin and certify my contribution under its conditions.

@jklgrasso

Copy link
Copy Markdown

With week numbers enabled, the last day in the calendar is cut off. Everything else looks good

@jacobgkau
jacobgkau requested a review from a team June 22, 2026 19:19

@jacobgkau jacobgkau left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also see the last weekday cut off on this branch, as shown in the PR description's screenshot. Just to be clear (with a formal review), that would need to be fixed for this to move forward.

Controllable by cosmic-settings with this commit:
NicolaiSoeborg/cosmic-settings@de3be06

Disclaimer; I used AI-tools to help me create this commit, but all code
has been "verified" by a human (me) before opening this PR.
This matches the current default design.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants