Conversation
an attempt at making thumbfast work on really old mpv versions. backported vanilla osc as well. not everything is implemented as a nice fallback, some newer features are just stripped out for the time being. I am currently using 0.14 in a linux vm. what works: initializing the script, thumbnail placeholders, launching slave process without errors what's broken: generating thumbnail files (they only get written when the slave process is exited), osc: title bar, osc: warnings for some keybinds features to emulate or guard, with what version they become available: ytdl: 0.7 input-ipc-server: 0.17 mp.get_osd_size: 0.17 (for osc) nil key in mp.add_key_binding: 0.17 timer:is_enabled: 0.18 mp.register_idle: 0.21 utils.subprocess_detached: 0.21 async command flag: 0.25 (for osc) expand-text: 0.25 (for osc) shortened mouse button names: 0.27 (for osc) mp.msg.trace: 0.28 utils.file_info: 0.28 load-stats-overlay: 0.28 utils.getpid: 0.29 load-osd-console: 0.31, oops! did 41c74d0 break 0.29 compat? load-auto-profiles: 0.33, oops! did 41c74d0 break 0.29 compat? scale and pad vf without explicit lavfi: ???? looking at this list, 0.28 support is trivial, 0.27 may introduce issues with our own file_info but should be fine+annoying keybind name changes needed in osc.lua, then 0.21 should be trivial, anything older requires us to find a solution for handling a detached mpv process ourselves
Owner
Author
|
Random isn't being seeded properly for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An attempt at making thumbfast work on really old mpv versions.
Backported vanilla OSC as well. not everything is implemented as a nice
fallback, some newer features are just stripped out for the time being.
I am currently using 0.14 in a Linux VM.
What works: initializing the script, thumbnail placeholders, launching
slave process without errors
What's broken: generating thumbnail files (they only get written when
the slave process is exited), osc: title bar, osc: warnings for some keybinds
Features to emulate or guard, with what version they become available:
ytdl: 0.7
input-ipc-server: 0.17
mp.get_osd_size: 0.17
(for osc) nil key in mp.add_key_binding: 0.17
timer:is_enabled: 0.18
load-script command: 0.21
mp.register_idle: 0.21
utils.subprocess_detached: 0.21
async command flag: 0.25
(for osc) expand-text: 0.25
(for osc) shortened mouse button names: 0.27
(for osc) mp.msg.trace: 0.28
utils.file_info: 0.28
load-stats-overlay: 0.28
utils.getpid: 0.29
load-osd-console: 0.31, oops! did 41c74d0 break 0.29 compat?
load-auto-profiles: 0.33, oops! did 41c74d0 break 0.29 compat?
scale and pad vf without explicit lavfi: ????
Looking at this list, 0.28 support is trivial, 0.27 may introduce issues
with our own file_info but should be fine+annoying keybind name changes
needed in osc.lua, then 0.21 should be trivial, anything older requires
us to find a solution for handling a detached mpv process ourselves