Add from_memory option - #92
Open
po5 wants to merge 1 commit into
Open
Conversation
Contributor
|
Maybe it could help those dying disks? |
Contributor
Owner
Author
Sadly it couldn't, we still write out every thumbnail to a file, and we read it at least once. Will fix the direct_io issue when I wake up, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Tried out mpv-thumbPreview's idea of getting the memory address of a string through ffi, and using it in
overlay-add.Peak
check_new_thumbwent from 161 to 535 microseconds,drawfrom 158 to 492 microseconds.So not helping in the speed department but not too awful either.
I've had the player crash once with it. Could be because I am constantly overwriting the value, and Lua may be getting rid of the data at the old address too quickly.
That aside, the benefit would be that we probably can't get into a situation where our data is overwritten while trying to display it?
I don't have much faith in this approach, just a curiosity.