[Magnus-K-work]

Related issue:
#1274 - Provisioning - Template extraction always sets page as Published

What is changed:
ProvisioningTemplateCreationInformation.cs - line 34 Added a propery that will control if extracted pages will be drafts or published. Defaults to state Published, to preserve original behavior.

ClientSidePageContentsHelper.cs - line 108, use value from template provisioning information object instead of setting to true.

Tests:
Not run in full, as many provisioning tests require installation of O365 Starter Intranet which is outdated/archived

Third public PR ever, please help me improve. :)

BR
Magnus

[Magnus-K-work]

@Adam-it
Should I start to move my 3 PRs to Pnp.Core.Provisioning?

Best regards
Magnus

[Adam-it]

@Magnus-K-work, thanks for pinging me up.
Short answer: IMPO yes 🙂.
We are not dropping PnP Framework Provisioning engine just yet, becasue the PnP.Core.Provisioning is in experimental state and for sure there are many leftovers not yet addressed, but as of now, we are fully committed to migrating to PnP Core and creating a single, more manageable tool that is more future-proof.
Not sure if any of the other maintainers will find time to go over the PRs in PnP Framework regarding the provisioning engine. I am very grateful for your and others' commitment to the many PRs opened towards improving the provisioning engine but the day has only 24 hours and I am unable to push both PnP Framework Provisioning and PnP.Core.Provisioning. My personal focus for now is the second one.
Also, please be aware I am closely monitoring the PRs opened in this repo that improve PnP Framework, and in the near future, when PnP.Core.Provisioning will be more stable, I plan to 'migrate' some of the most valuable PR as new once in PnP Core repo so that the hard work done by our contributors won't get lost. That being said if you wanna help out and open a PR in PnP Core repo to improve PnP.Core.Provisioning now, you are more than welcome to do so 🙂.
Let me know what you think.
Also, did you already have a chance to try out PnP.Core.Provisioning? I am currently working in PnP PowerShell to add a new -experimental option that will allow you to use it over PnP PS, so that it will be easier for folks to transition to the new engine in near future.

BTW, thanks for your work and contributions to the PnP Framework. You Rock 🤩. And as I said already, I will do my very best so that the work done will not get lost, but 'moved' to PnP Core once the time is right 👍

[Magnus-K-work]

@Adam-it
OK, I understand. I'll try to find time to adapt my PRs to PnP.Core.Provisioning. Thanks for your hard work for this!

I haven't gotten to reimplement my test project for PnP.Core.Provisioning, just had a quick look and realized that I have to implement the PnP.Core authentication parts as they differ from my current PnP.Framework stuff. I have put it on my list, I'd like to know how that works anyways. 😃

BR
Magnus

[Magnus-K-work]

Tested the original PnP.Core.Provisioning 1.18.35-nightly on my test project (makes a template out of a site, removes all but one page from the template, applies the template to another site) and it works like the PnP.Framework provisioning did. (E.g. works but I can see the layout bug present in PnP.Core.Provisioning)

I'll try to find time to create issues and PRs in PnP.Core.Provisioning for my three PnP.Framework PRs. 👍

BR
Magnus

[Adam-it]

LGTM 🔥