Migrate core.py to numpy arrays for performance - #514
Open
lnzeta wants to merge 1 commit into
Open
Conversation
timkpaine
requested changes
Apr 27, 2026
timkpaine
left a comment
timkpaine
left a comment
Collaborator
There was a problem hiding this comment.
Needs to be split, and we will use hatchling
Contributor
Author
|
Changed config to use hatchling |
timkpaine
changed the title
timkpaine
self-requested a review
April 29, 2026 22:42
timkpaine
requested changes
Apr 29, 2026
timkpaine
left a comment
timkpaine
left a comment
Collaborator
There was a problem hiding this comment.
I'm going to add some benchmarks first so we can properly track performance over time.
Collaborator
will take a look if this can be improved. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed a significant performance regression updating from 1.1.2.
After some analysis I think it is due to having to use iloc in core.py after the pandas upgrade.
I therefore switched to using mostly numpy internally, and it seems the performance is comparable to pre-upgrade.
I also updated the project to use only pyproject.toml and uv for convenience of setting up a local test env. All github actions and makefile are updated accordingly.