Skip to content

Fix CI, fix tests, bidirectional type bug, typos - #49

Merged
ptamarit merged 5 commits into
plazi:mainfrom
ptamarit:ci-fix-upgrade-dependencies
Sep 7, 2026
Merged

ptamarit merged 5 commits into
plazi:mainfrom
ptamarit:ci-fix-upgrade-dependencies

Conversation

@ptamarit

@ptamarit ptamarit commented May 7, 2026 •

Copy link
Copy Markdown
Collaborator

To be reviewed commit by commit:

  • ci: upgrade actions and use installed ruff instead of ruff action
    • Some actions were raising a warning about Node.js 20
    • Using the ruff action re-installs ruff (by default the latest version matching the pyproject.toml constraints); one problem is that this version will be greater than the locked one (although this can be fixed with the option version-file: "uv.lock"); the other problem is that it re-downloads ruff even though it is already installed as a dependency, so it is faster to execute it directly
  • tests: initialize projects with empty token
    • Tests were blocking waiting for the token to be provided by the user on the CLI
  • tests: use json.loads instead of eval
    • Entries with a null value were not properly supported by eval (raising NameError: name 'null' is not defined)
  • fix: bidirectional storing matching boolean type
    • We were using strings with values "True" and "False", but this was causing SQLAlchemy to raise the error sqlalchemy.exc.StatementError: (builtins.TypeError) Not a boolean value: 'True'
  • chore: fix typos
    • A few typos I found

@ptamarit
ptamarit force-pushed the ci-fix-upgrade-dependencies branch 3 times, most recently from 3e2c9fe to 400efec Compare May 7, 2026 12:37
@ptamarit ptamarit changed the title Upgrade locked dependencies and fix ruff checks Upgrade locked dependencies, fix ruff checks and tests May 7, 2026
@ptamarit ptamarit changed the title Upgrade locked dependencies, fix ruff checks and tests Upgrade locked dependencies, fix ruff checks, tests, bidirectional bug May 8, 2026
@ptamarit
ptamarit requested a review from slint May 21, 2026 09:38
@ptamarit
ptamarit force-pushed the ci-fix-upgrade-dependencies branch 7 times, most recently from 8065edf to 61f9fe6 Compare September 7, 2026 06:06
@ptamarit ptamarit changed the title Upgrade locked dependencies, fix ruff checks, tests, bidirectional bug Fix CI, fix tests, bidirectional type bug, typos Sep 7, 2026
Comment thread .github/workflows/tests.yml Outdated
@ptamarit
ptamarit force-pushed the ci-fix-upgrade-dependencies branch 2 times, most recently from 996e92e to f6bda91 Compare September 7, 2026 06:52
@ptamarit
ptamarit merged commit 407e381 into plazi:main Sep 7, 2026
1 check passed
@ptamarit
ptamarit deleted the ci-fix-upgrade-dependencies branch September 7, 2026 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants