Skip to content

Anchor the AppleWebKit 15.4 antialias workaround UA match - #9265

Merged
willeastcott merged 1 commit into
mainfrom
fix-webkit-15-4-ua-match
Aug 31, 2026
Merged

Anchor the AppleWebKit 15.4 antialias workaround UA match#9265
willeastcott merged 1 commit into
mainfrom
fix-webkit-15-4-ua-match

Conversation

@willeastcott

Copy link
Copy Markdown
Contributor

Description

The #4136 workaround matched '15.4' anywhere in the UA, and every Chromium UA contains 'AppleWebKit', so any unrelated 15.4 token (a Chrome build number, an OS patch version) could force-disable antialiasing on a non-Safari browser. The match is now anchored to Version/15.4 and OS 15_4, which still covers desktop Safari 15.4/15.4.1 and all iOS 15.4 WebKit browsers (including CriOS/FxiOS).

Checked against eight real UA strings: the four affected Safari/WebKit 15.4 variants still trigger; Chrome 115.4.x builds and macOS Catalina (10_15_4) no longer false-positive.

Fixes #9259

Verified: lint clean; unit suite at the main baseline (2337 passing).

Checklist

  • I have read the contributing guidelines
  • My code follows the project's coding standards
  • This PR focuses on a single change

🤖 Generated with Claude Code

'15.4' matched anywhere in the UA, and every Chromium UA contains
'AppleWebKit', so unrelated version tokens (e.g. a Chrome build number
or patch version) could force-disable antialiasing. Match the anchored
Safari tokens Version/15.4 and OS 15_4 instead, which still cover
desktop Safari 15.4/15.4.1 and all iOS 15.4 WebKit browsers. Fixes #9259.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

Build size report

This PR changes the size of the minified bundles.

Bundle Minified Gzip Brotli
playcanvas.min.js 2390.4 KB (+0.0 KB, +0.00%) 614.7 KB (+0.0 KB, +0.00%) 476.9 KB (−0.1 KB, −0.02%)
playcanvas.min.mjs 2387.8 KB (+0.0 KB, +0.00%) 613.4 KB (+0.0 KB, +0.00%) 476.5 KB —

@willeastcott
willeastcott merged commit b87cdcd into main Aug 31, 2026
10 checks passed
@willeastcott
willeastcott deleted the fix-webkit-15-4-ua-match branch August 31, 2026 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AppleWebKit 15.4 antialias workaround matches '15.4' anywhere in the UA string

2 participants