Use textureFloatFilterable for VSM_32F shadow filtering - #9263
Open
willeastcott wants to merge 1 commit into
Open
Use textureFloatFilterable for VSM_32F shadow filtering#9263willeastcott wants to merge 1 commit into
willeastcott wants to merge 1 commit into
Conversation
extTextureFloatLinear is a raw WebGL extension object, undefined on WebGPU, so VSM32 shadows were silently sampled with nearest filtering there even though light.js approves the shadow type based on the portable textureFloatFilterable flag. Identical on WebGL, where textureFloatFilterable is derived from the same extension. Fixes #9257. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Build size reportThis PR changes the size of the minified bundles.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ShadowMappicked the VSM32 filter fromdevice.extTextureFloatLinear— a raw WebGL extension object that is undefined on WebGPU — so VSM32 shadows were silently sampled with nearest filtering there, even thoughlight.jsapprovesSHADOW_VSM_32Fbased on the portabledevice.textureFloatFilterableflag. This switches to the same flag. On WebGL the behaviour is identical, sincetextureFloatFilterableis derived directly from that extension.Fixes #9257
Verified: lint clean; unit suite at the
mainbaseline (2337 passing).Checklist
🤖 Generated with Claude Code