Remove WebGL1-era POT checks from texture mipmap upload and gpuSize - #9262
Open
willeastcott wants to merge 1 commit into
Open
Remove WebGL1-era POT checks from texture mipmap upload and gpuSize#9262willeastcott wants to merge 1 commit into
willeastcott wants to merge 1 commit into
Conversation
WebGL1 forbade mipmaps on NPOT textures; WebGL2 does not. The upload early-out skipped mipmap-only uploads for every NPOT texture, and gpuSize ignored mip memory for NPOT mipmapped textures. Fixes #9256. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Build size reportThis PR changes the size of the minified bundles.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
WebGL1 forbade mipmaps on NPOT textures; WebGL2 (the engine's minimum) does not. Two leftovers of that restriction:
WebglTexture#uploadearly-returned any mipmap-only upload for NPOT textures (|| !texture.pot), so e.g. enablingmipmapsafter creation silently did nothing for NPOT. The redundant-upload guard (_needsMipmapsUpload && _mipmapsUploaded) is kept.Texture#gpuSizeexcluded mip memory for NPOT mipmapped textures, under-reporting VRAM stats.These were the only two consumers of
Texture#pot, which remains as public API.Behavioural note: NPOT textures with
mipmaps: truethat previously skipped mip regeneration will now generate them (correct filtering, slightly more VRAM — as WebGPU already behaves).Fixes #9256
Verified: lint clean; unit suite at the
mainbaseline (2337 passing).Checklist
🤖 Generated with Claude Code