Add a Tonemapping and Exposure page for Gaussian splats - #1164
Draft
mvaligursky wants to merge 3 commits into
Draft
Add a Tonemapping and Exposure page for Gaussian splats#1164mvaligursky wants to merge 3 commits into
mvaligursky wants to merge 3 commits into
Conversation
Splats are unlit, so it is not obvious that the camera tone curve, the scene exposure and fog still apply to their stored colors. Documents that pipeline plus the two switches that opt out of it: the new Scene.gsplat.useTonemap and the existing Scene.gsplat.useFog. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The scene settings keys are editor/serialization plumbing, not the API to point users at - the Scene.gsplat properties are. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents how Gaussian splat colors reach the framebuffer, and how to take them out of that pipeline.
Splats are unlit, which makes it easy to assume nothing in the scene affects them — but their output still goes through the camera tone curve,
Scene.exposureand fog, so grading the lit content of a scene also shifts the splats. The new page covers that, the two opt-out switches, and what each one does:Scene.gsplat.useTonemap— skips the tone curve and the exposure multiplier for splats only (engine PR Add scene.gsplat.useTonemap to opt Gaussian splats out of tonemapping and exposure engine#9229).Scene.gsplat.useFog— existing, previously undocumented.It also notes that the two are independent (fog still applies with tonemapping off), that both are scene-wide rather than per-component, and lists the equivalent
applySceneSettingskeys.Added to the sidebar under Building Splat Applications, after Fisheye Rendering.
Notes for reviewers
Draft: gated on the 2.22 engine release.
Scene.gsplat.useTonemaplands with playcanvas/engine#9229, so this should only be merged once 2.22 ships and the API reference has it. Everything else on the page describes existing behavior.npm run lintandnpm run buildboth clean.