Repository navigation
fix: align drop shadow blur resolution - #529
Open
darshan-Jahagirdar wants to merge 1 commit into
Open
darshan-Jahagirdar wants to merge 1 commit into
darshan-Jahagirdar wants to merge 1 commit into
Conversation
Author
|
Validation run for this PR:
All of the above passed locally. I used |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
DropShadowFilter already accepts a
resolutionoption and applies it to the outer drop-shadow pass, but the internalKawaseBlurFilterstill used the default filter resolution. On high-DPR devices such as Retina Macs and iPhones, that can make the blur passes run at renderer/device resolution even when DropShadowFilter defaults to resolution 1.This aligns the internal blur pass with the configured DropShadowFilter resolution.
Why
The expensive part of DropShadowFilter is the repeated Kawase blur pass. Keeping that internal blur pass at the configured filter resolution avoids silently scaling the intermediate blur work by DPR on high-density displays.
Related to #327.
Validation
npm ci --ignore-scriptsto avoid the local Windows/Node 24canvasnative build requirementnpm run typesnpm run lintpasses with existing CRLF warnings and 0 errorsnpm run buildpasses with existing CRLF warnings and 0 errors