Skip to content

fix: align drop shadow blur resolution - #529

Open
darshan-Jahagirdar wants to merge 1 commit into
pixijs:mainfrom
darshan-Jahagirdar:codex/drop-shadow-blur-resolution
Open

darshan-Jahagirdar wants to merge 1 commit into
pixijs:mainfrom
darshan-Jahagirdar:codex/drop-shadow-blur-resolution

Conversation

@darshan-Jahagirdar

Copy link
Copy Markdown

What changed

DropShadowFilter already accepts a resolution option and applies it to the outer drop-shadow pass, but the internal KawaseBlurFilter still used the default filter resolution. On high-DPR devices such as Retina Macs and iPhones, that can make the blur passes run at renderer/device resolution even when DropShadowFilter defaults to resolution 1.

This aligns the internal blur pass with the configured DropShadowFilter resolution.

Why

The expensive part of DropShadowFilter is the repeated Kawase blur pass. Keeping that internal blur pass at the configured filter resolution avoids silently scaling the intermediate blur work by DPR on high-density displays.

Related to #327.

Validation

  • npm ci --ignore-scripts to avoid the local Windows/Node 24 canvas native build requirement
  • npm run types
  • npm run lint passes with existing CRLF warnings and 0 errors
  • npm run build passes with existing CRLF warnings and 0 errors

@darshan-Jahagirdar

Copy link
Copy Markdown
Author

Validation run for this PR:

  • npm ci --ignore-scripts
  • npm run types
  • npm run lint
  • npm run build
  • git diff --check

All of the above passed locally. I used --ignore-scripts for install because this Windows/Node 24 environment cannot build canvas@2.11.2 without native VS C++ build tooling; the project build/type/lint steps passed after installing dependencies.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant