Repository navigation
Conversation
maoxor
added a commit
to maoxor/pipecat
that referenced
this pull request
Oct 29, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
asyncio.iscoroutinefunction is deprecated since Python 3.14 and slated for removal in 3.16. The action manager called it for every custom action it ran.
maoxor
force-pushed
the
inspect-iscoroutinefunction
branch
from
October 29, 2026 16:01
06446a4 to
1154f14
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please describe the changes in your PR. If it is addressing an issue, please reference that as well.
ActionManagerinpipecat/flows/actions.pydecides whether toawaita custom action handler withasyncio.iscoroutinefunction. That function is deprecated since Python 3.14 and slated for removal in 3.16. So every custom action on 3.14+ emits aDeprecationWarning, and on 3.16 running a custom action would raiseAttributeError. This switches both checks (flow-manager-aware handlers and legacy single-argument handlers) toinspect.iscoroutinefunction, the documented replacement (inspectwas already imported). For handlers, both functions give the same result on 3.11+.What I ran. The flag is
-W "error:'asyncio.iscoroutinefunction':DeprecationWarning:pipecat.flows.actions":test_flows_actions.py,test_flows_manager.py,test_flows_flow.pymainuv run pytest) on 3.14: 9103 passed, 71 skipped.ruff check/ruff format --check: clean.changelog/6467.fixed.md.