Conversation
Member
Author
|
I really hate this Github bug |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3513 +/- ##
==========================================
- Coverage 86.20% 86.14% -0.06%
==========================================
Files 82 81 -1
Lines 10511 10628 +117
==========================================
+ Hits 9061 9156 +95
- Misses 1012 1032 +20
- Partials 438 440 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This includes the local patch I'm using to develop dtls@v4 and detachedConn API pion/dtls#1094
Based on pion/ice#967 and pion/stun#291 and includes all the DTLS changes needed to update to @v4 once we tag it.
The DetachedConn API significantly simplifies our conn layer, and removes the mux package and the need to make a fake packetconn which was a case for many bugs and isuses in the past espically with deadlines:
examples: #3295 and #3314 and by extension this made handling graceful shutdown in SCTP really complex and really hard to manage pion/sctp#441 pion/sctp#483 (this can be simplified now) ...