Make Docker cleanup project-scoped#1725
Open
vaanuthanesh2003 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the
clean_dockerMakefile target to avoid using global Docker cleanup.Previously,
make cleanrandocker system prune --volumes, which can remove unused Docker resources from unrelated projects on the developer's machine.This change scopes Docker cleanup to Querybook's development and test Docker Compose resources instead.
Why
This prevents accidental deletion of Docker volumes, networks, and caches belonging to other local development projects.
Fixes #1663.
Testing
make -n clean_dockerto confirm Docker cleanup is scoped to Querybook Compose filesmake clean_dockerand confirmed it no longer callsdocker system prune --volumes