fix(grok): skip set_model when effort is unchanged or a prompt is in flight - #7980
fix(grok): skip set_model when effort is unchanged or a prompt is in flight#7980maria-rcks wants to merge 1 commit into
All clear
All clear
Details
Note
Your check run agent prompt is: .macroscope/check-run-agents/effect-service-conventions.md
More information about how Check Run Agents work can be found in our Help Center.
🔍 Agent activity — 4 tool calls
💭 I'm examining the diff across GrokAdapter.ts, GrokAcpSupport.ts, and their tests to check convention adherence—looking at how imports from "effect" are structured, how the ctx field gets mutated, and how errors are handled.
1. browse_code — apps/server/src/provider/acp/GrokAcpSupport.ts
2. browse_code — apps/server/src/provider/Layers/GrokAdapter.ts
💭 The code looks conventional, with namespaced imports and behavioral changes in a Grok adapter plus added tests. I want to check the test file's head to see what it imports from "effect", things like Fiber and TestClock.
3. browse_code — apps/server/src/provider/Layers/GrokAdapter.test.ts
4. browse_code — apps/server/src/provider/acp/GrokAcpSupport.test.ts
💭 Everything checks out—conventions are followed, imports are namespaced, no new services or errors, and the behavior change has test coverage. There's a slight tension between the instruction to respond exactly "All clear" and the schema requiring JSON output, so I'll fit "All clear" into the summary field with a success state.
Agent Credits: 30 credits