Skip to content

pkg/ddl/tests/tiflash: stabilize flaky TestTiFlashProgressAfterAvailable (#68122) #69032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ti-chi-bot merged 1 commit into from
Jun 11, 2026
Merged

pkg/ddl/tests/tiflash: stabilize flaky TestTiFlashProgressAfterAvailable (#68122) #69032

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions pkg/ddl/tests/tiflash/ddl_tiflash_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,10 +104,12 @@ func createTiFlashContext(t *testing.T) (*tiflashContext, func()) {
s.dom.SetStatsUpdating(true)

tearDown := func() {
s.dom.Close()
s.tiflash.Lock()
s.tiflash.StatusServer.Close()
if s.tiflash.StatusServer != nil {
s.tiflash.StatusServer.Close()
}
s.tiflash.Unlock()
s.dom.Close()
require.NoError(t, s.store.Close())
ddl.PollTiFlashInterval = 2 * time.Second
}
Expand Down Expand Up @@ -1124,12 +1126,13 @@ func TestTiFlashFailureProgressAfterAvailable(t *testing.T) {
func TestTiFlashProgressAfterAvailable(t *testing.T) {
s, teardown := createTiFlashContext(t)
defer teardown()
tk := testkit.NewTestKit(t, s.store)
se := session.CreateSessionAndSetID(t, s.store)
defer se.Close()

tk.MustExec("use test")
tk.MustExec("drop table if exists ddltiflash")
tk.MustExec("create table ddltiflash(z int)")
tk.MustExec("alter table ddltiflash set tiflash replica 1")
session.MustExec(t, se, "use test")
session.MustExec(t, se, "drop table if exists ddltiflash")
session.MustExec(t, se, "create table ddltiflash(z int)")
session.MustExec(t, se, "alter table ddltiflash set tiflash replica 1")
time.Sleep(ddl.PollTiFlashInterval * RoundToBeAvailable * 3)
CheckTableAvailable(s.dom, t, 1, []string{})

Expand Down